Skip to content

Remove unused return value of MPI calls.#6028

Merged
prckent merged 2 commits into
QMCPACK:developfrom
ye-luo:remove-mpi-return
Jul 8, 2026
Merged

Remove unused return value of MPI calls.#6028
prckent merged 2 commits into
QMCPACK:developfrom
ye-luo:remove-mpi-return

Conversation

@ye-luo

@ye-luo ye-luo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Consistently not checking the return value of MPI calls. This safe to do in MPI since we don't customize error handler and every failure is immediate abort. This reduces compiler warning about unused ierr.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Laptop

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo ye-luo force-pushed the remove-mpi-return branch from 37d9c4e to 9066cfb Compare July 7, 2026 20:41
@ye-luo

ye-luo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Test this please

@prckent

prckent commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Test this please

@prckent prckent enabled auto-merge July 7, 2026 23:07
@prckent prckent merged commit 8d46102 into QMCPACK:develop Jul 8, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants